From d0d792aecbacf20372d3bee540c97da9054e344f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thorben=20G=C3=BCnther?= Date: Thu, 4 May 2023 16:56:43 +0200 Subject: [PATCH] ansible-lint: Fix handler commands ansible-lint complains about: no-changed-when: Commands should not change things if nothing needs doing. This can simply be ignored because these handlers only get called if something needs to be done. --- roles/mumble_server/handlers/main.yml | 2 +- roles/sinusbot/handlers/main.yml | 2 +- roles/srht/handlers/main.yml | 16 ++++++++-------- roles/wireguard/handlers/main.yml | 2 +- roles/wireguard_vpn_server/handlers/main.yml | 2 +- 5 files changed, 12 insertions(+), 12 deletions(-) diff --git a/roles/mumble_server/handlers/main.yml b/roles/mumble_server/handlers/main.yml index 523998a..4324edd 100644 --- a/roles/mumble_server/handlers/main.yml +++ b/roles/mumble_server/handlers/main.yml @@ -1,5 +1,5 @@ --- -- name: Set supw +- name: Set supw # noqa no-changed-when ansible.builtin.command: mumble-server -ini /etc/mumble/mumble-server.ini -supw "{{ mumble_secrets['su_password'] }}" become: true become_user: _mumble-server diff --git a/roles/sinusbot/handlers/main.yml b/roles/sinusbot/handlers/main.yml index a98481b..6883dbe 100644 --- a/roles/sinusbot/handlers/main.yml +++ b/roles/sinusbot/handlers/main.yml @@ -1,5 +1,5 @@ --- -- name: List scripts +- name: List scripts # noqa no-changed-when ansible.builtin.shell: ls /opt/sinusbot/sinusbot_scripts/*.js register: sinusbot_scripts listen: Setup scripts diff --git a/roles/srht/handlers/main.yml b/roles/srht/handlers/main.yml index 2c81a81..1262aee 100644 --- a/roles/srht/handlers/main.yml +++ b/roles/srht/handlers/main.yml @@ -10,7 +10,7 @@ name: builds.sr.ht-worker state: restarted -- name: Init srht-meta +- name: Init srht-meta # noqa no-changed-when ansible.builtin.command: metasrht-initdb - name: Debug message @@ -18,25 +18,25 @@ msg: Please create oauth clients for each service listen: Init srht-meta -- name: Init srht-builds +- name: Init srht-builds # noqa no-changed-when ansible.builtin.command: buildsrht-initdb -- name: Init srht-git +- name: Init srht-git # noqa no-changed-when ansible.builtin.command: gitsrht-initdb -- name: Init srht-hub +- name: Init srht-hub # noqa no-changed-when ansible.builtin.command: hubsrht-initdb -- name: Init srht-lists +- name: Init srht-lists # noqa no-changed-when ansible.builtin.command: listssrht-initdb -- name: Init srht-man +- name: Init srht-man # noqa no-changed-when ansible.builtin.command: mansrht-initdb -- name: Init srht-paste +- name: Init srht-paste # noqa no-changed-when ansible.builtin.command: pastesrht-initdb -- name: Init srht-todo +- name: Init srht-todo # noqa no-changed-when ansible.builtin.command: todosrht-initdb - name: Prune images diff --git a/roles/wireguard/handlers/main.yml b/roles/wireguard/handlers/main.yml index c8ccd96..63c7e9c 100644 --- a/roles/wireguard/handlers/main.yml +++ b/roles/wireguard/handlers/main.yml @@ -1,5 +1,5 @@ --- -- name: Reload network +- name: Reload network # noqa no-changed-when ansible.builtin.command: "{{ item }}" with_items: - networkctl delete wg0 diff --git a/roles/wireguard_vpn_server/handlers/main.yml b/roles/wireguard_vpn_server/handlers/main.yml index 3884e36..a95f7e7 100644 --- a/roles/wireguard_vpn_server/handlers/main.yml +++ b/roles/wireguard_vpn_server/handlers/main.yml @@ -1,5 +1,5 @@ --- -- name: Reload VPN network +- name: Reload VPN network # noqa no-changed-when ansible.builtin.command: "{{ item }}" with_items: - networkctl delete wg1 -- 2.44.0